Conversation
Notices
-
@widget And how'd that turn out?
Monday, 17-Sep-12 01:11:59 UTC from web-
@widget I could've sworn I fixed that. Hold on a tick, I think I must've not committed a change somewhere.
-
@widget http://stackoverflow.com/questions/1223354/undo-git-pull-how-to-bring-repos-to-old-state (Explains it much better than I could possibly do within the limits of this text field.)
Toksyuryel likes this. -
@widget Also, I found the problem. Pushed the fix now, and it seems github automatically rolled it into the pull-request. I'm not entirely happy with the solution, since calling profile links notices is semantically hairy, but evidently the actual .profiles selector was coming from either the theme or RDNPlus, not the base setup, so I can't use it without hacking up the CSS and hoping all the themes do too.
-
@widget Yeah, it's nice. Also shows all refs rather than just the ones that are parents/grandparents/etc. of the current HEAD, which can be handy if you manage to really mess up your repo somehow.
-
@bitshift ...What _are_ you doing with it, by the way?
-
@redenchilada Making the "new users"/"popular groups" sections not be <table>s (since all the other similar sections are <ol>s), and as a handy side-effect fixing the thing where their links overflow without having to add another CSS rule.
-
@widget Yep. There's literally only one change in the new commit, so it should be pretty easy to see if you have it locally or not: https://github.com/bit-shift/rainbowdash-network/commit/bc2a093f63e020ff608cfc145a89a37bbc627e4d
-
@widget Hm yeah, it's definitely live (and still messed up) on your test instance. Poking about a bit with the live page via firebug to figure out what on earth is making it work for me, but break over there.
-
@widget Doing it the old way causes links to overflow out of the sidebar, because tables don't have `word-wrap: break-word` applied. Fixing the emitted HTML (which is what I've mostly done, I just need to figure out what I'm still missing) seems a lot better than every theme needing to add that rule.
-
@widget (It's also more consistent, though I wouldn't have bothered if that was the only difference.)
-
@widget Hm?
-
@widget I'd use word-wrap: break-word;
-
@widget overflow: hidden; is an ugly way of cutting words imo. Do a graceful cut using some code instead.
-
@widget It also overflows the group notices thing (that was the other bit I fixed), and that will actually have links that long, potentially. Plus, that involves setting CSS rules, and then we're back to the problem of needing _every_ theme to use that same rule
-
@widget Yah, determine the minimum value and get a data value or a class on it's wrapping element to clean it up using some Javascript I'd say.
-
@widget Anyway, I found what I'd missed, and as I expected, it was something stupidly obvious in hindsight. About to make one last push, and this _will_ fix it, because it'll change it to be exactly the same as what's demonstrably working on your test site if I live-edit the same changes in.
-
@zeeraw minimum width*
-
@widget It's now showing up in github's web UI, so pulling now should finally fix it. Sorry for causing so much hassle, I should've tested without RDNplus and a theme on before I started committing my changes. :(
-
@widget Also, take a look on it from the perspective that allowing too slim of a layout might be a fundamental design flaw.
-
@zeeraw It's stuff like this that makes me wonder why we're still using StatusNet. :/
-
@minti Other than "we're all too lazy to code our own"
-
@widget "Did you mean: @commodorecrazycommanderofthefirstroyalbrigadeofspiceracksandcheese?"
-
@widget It works cause it implements OStatus. I'm sure we could also do that.
-
Awww, that's not right either? I used to remember this one without checking. :(
-
@widget Then that's the design flaw :D When I build services I just look at what patterns and paradigms Twitter use for their details. They are usually right.
-
@minti OStatus is sufficiently geared to an architecture very much like status.net that you would effectively be coding under the exact same limitations, and end up with just another status.net.
-
@minti There is a guy in the fandom that nicks Scan who's really talented. He's working on a twitterish like service http://neighr.com/
-
@zeeraw Oh gawd! That animation for loading more post is #SoAwesome.
-
@zeeraw It doesn't seem to load anything at all with javascript switched off. That's not great. (It's both possible [i]and[/i] preferable to gracefully fallback in such a situation.)
-
@bitshift Yeah but, the actual codebase would be clean and use actual *TEMPLATES* for functions. xD
-
@minti True. Just seems like a lot of wasted effort when the protocol would still limit you to making something that can't really have a competitive edge beyond "yeah, but our code is cleaner".
-
@bitshift The main problem is us though. With a custom codebase we could probably shave off maybe 60% of the processing, and like 40% of the memory usage.
-
@widget I have time and will, I just don't have the dedication. :/
-
@widget I'll rewrite it! (Don't get mad when it's only 10 lines of code though.)
-
@widget I'm totally willing! I'd just give up after a day calling it a useless project. ;p
-
@thatonestocking SHUT UP HOW DO I ENGLISH ;_________;
-
@widget It's not totally useless, it would be a neat learning experience to say the least. :p
-
@widget s/$action->element/oh god how do I regex replace all the dom building with raw html
-