Conversation
Notices
-
@hannes2peer I noticed, with repeats, the tag for the remote instance is for the instance that repeated it, instead of where the notice was originally posted, This seems like it could be confusing?
For instance, recently takanamy (who is on quitter.se) repeated something from nee (who is on a private instance), and the remote notice URL is in fact for quitter.se
Is this by design? Is there a way we could tag it by the original instance that the notice was posted on, rather than the person who reposted it (or ideally, both?)-
@maiyannah not sure, but my guess is that it happened because nee didn't have any followers on your instance when taknamay repeated
-
@maiyannah now when you follow nee it looks like it has been corrected on https://community.highlandarrow.com/notice/118598
-
@hannes2peer This even happens when my own notices are repeated. I am not sure if it is gnuSocial or Qvitter that does that tagging though.
-
@hannes2peer That could be a seperate problem though, because I notice things get a little funny when it's your own notice sometimes.
-
@maiyannah but of course it would be better if the permalink was to nee's instance from the beginning
-
@maiyannah hm but what do you mean by "tag"?
-
@hannes2peer Well it looks like what happens, is the link does go to the original notice, but it gets tagged as from the repeating instance.
-
@hannes2peer The data-uri property points to the repeating instance, but the actual a href goes to the original instance specifically.
-
@hannes2peer Here is an illustration to show what I mean https://community.highlandarrow.com/attachment/27932
-
@hannes2peer (I typod @takegrapeakenji 's instance name in the note but I think you can see what I mean)
-
@maiyannah still not sure exactly what you mean. are you referring to the URI in the "data-uri" attribute?
-
@hannes2peer Yep! As far as I can tell the a href is the original notice, but the data-uri is the "copy" of the notice on the server that repeated it. I'm not sure if this is intended or not. It seems to me though like it's best to have it point to the original notice, not a copy.
-
@maiyannah the data-uri attribute is referring to the _repeat_ not the _repeated notice_, and that design is intentional
-
@maiyannah do you need the uri of the _repeated notice_ for some reason? in that case we could easily add an data-original-uri attribute
-
@hannes2peer That would be ideal, because I use these attributes for the "remote instance icons" CSS I use (and I am pretty sure @moonman does too), and it becomes confusing to have for instance the quitter.se icon on a notice that isn't from quitter.se
The data-original-uri attribute you suggest would fix this easily! So that would be nice to have :) -
@hannes2peer I think I managed this by adding into dom_functions.js this bit on line 2305:
data-original-uri="' + obj.external_url + '" \
But I'm not sure if this is 100% correct. -
@maiyannah why don't you use the href attribute in the ostatus-link element?
.ostatus-link[href*="://quitter.se/"] { } -
@hannes2peer I can't remember what issue I had but for some reason that didn't work. Let me try now.
-
@hannes2peer Oh I remember, I didn't want to have to bother changing css if the instance goes between http and https, but your version there sidesteps that.
-
@hannes2peer Thanks!
-
@hannes2peer (ccing @moonman so he can see this too since it works better for attaching remote instance icons)
-
