Conversation

Notices

  1. On my instance: "Error setting user. Missing authorization header data. Please logout and login " http://u.daggsy.com/Hc

    Logging out and in doesn't do anything.  This is likely due to recent !qvitter changes.

    Sunday, 08-Jan-17 23:52:49 UTC from gs.kawa-kun.com
    1. @takeappleakenji The CSRF thing probably, but I this is the first I've heard of that problem.  /cc @hannes2peer

      Sunday, 08-Jan-17 23:54:11 UTC from community.highlandarrow.com
      1. @maiyannah @hannes2peer Yeah, it's definitely the CSRF thing.  QvitterPlugin.php:1309 is in the if(!isset($_SERVER['HTTP_X_QVITTER_CSRF']) block here: http://u.daggsy.com/Hd

        Sunday, 08-Jan-17 23:55:39 UTC from gs.kawa-kun.com
        1. @takekiwiakenji @hannes2peer While it probably isn't the problem superglobals are considered a bad practice.

          Sunday, 08-Jan-17 23:56:38 UTC from community.highlandarrow.com
          1. @maiyannah @takepapayaakenji @hannes2peer Me and some SPC users had a problem where we would get logged out after closing the browser.  Seems like this may be it.

            Sunday, 08-Jan-17 23:58:50 UTC from gs.archae.me
            1. @archaeme @hannes2peer @maiyannah I restarted php-fpm and the queue daemons in the normal order (including checkschema), then logged out and in.  Still no dice.

              Monday, 09-Jan-17 00:01:07 UTC from gs.kawa-kun.com
              1. @takebatcaveakenji @maiyannah @hannes2peer I'm pretty confident it's the CSRF patch that caused it.  Didn't occur before the update.

                Monday, 09-Jan-17 00:02:16 UTC from gs.archae.me
                1. @archaeme @hannes2peer @takemangoakenji Thought occurs to me that in certain php setups the plugin might not be able to add the http header it's looking for.

                  Monday, 09-Jan-17 00:02:55 UTC from community.highlandarrow.com
                2. @archaeme @hannes2peer @maiyannah Cool.

                  By the way, I don't see where HTTP_X_QVITTER_CSRF is set. https://hastebin.com/raw/araxicosus

                  Monday, 09-Jan-17 00:03:13 UTC from gs.kawa-kun.com
                  1. @takepapayaakenji @hannes2peer @archaeme Im not very familiar with Hannes' patch beyond helping fix an image upload problem it's why I CC'd him, he'd know better than I.

                    Monday, 09-Jan-17 00:04:52 UTC from community.highlandarrow.com
                    1. @maiyannah @takecherryakenji @archaeme you can probably safely downgrade to before that fix. it was an issue with older versions of gs.

                      Monday, 09-Jan-17 00:18:33 UTC from quitter.se
                      1. @maiyannah @takePotato Knishesakenji @archaeme i might have to rethink that fix altogether

                        Monday, 09-Jan-17 00:18:57 UTC from quitter.se