Conversation
Notices
-
@maiyannah
1. This wasn't a regex, this was a bug in the exception code.
2. You'll only be shooting yourself in the foot if you don't use lookbehinds and word boundaries for stuff like this.-
@takecherryakenji I don't understand what would've caused an internal server error, especially only for local users. And I don't immediately see the practical change in the regex. You replaced the initial bit with a negative lookback for non-whitespace and then seemingly simplified the user-part (which is of course good and I think I'll copy).
@takeappleakenji I've even replied to you, so I obviously don't block: https://gs.kawa-kun.com/notice/1556135-
@mmn
1. The internal server error is what was happening and this fixed it. I can't explain it any more than that.
2. There was a really nasty bug with the old regex that would cause any remote WebFingers to fail to be detected if there were any local @-mentions at the beginning of a notice, which resulted in a lot of complains from folks I follow. I did a lot of testing with the old regex and the results didn't make sense, so I tossed out the first half of it and redid it.
Redoing the first half has fixed remote WebFingers on several GS and pA instances, so you can't deny that the fix isn't doing its job.
-
-
